Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1027 +/- ##
==========================================
+ Coverage 92.11% 92.15% +0.03%
==========================================
Files 49 49
Lines 7537 7542 +5
==========================================
+ Hits 6943 6950 +7
+ Misses 594 592 -2
🚀 New features to boost your workflow:
|
Member
|
Very much interesting and we did something similar for anndata: scverse/anndata#1959 Feel free to consider our approach that we used there. |
Contributor
Author
|
Oh thanks @Zethson, your approach seems much better and very straightforward, I'll try that! |
Contributor
Author
|
I made the change, WDYT @Zethson? |
Member
|
Looks fine but I'll leave this PR up to the maintainers now. |
Member
|
LGTM thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
torchis installed, importing spatialdata will also importtorchbecause ofImageTilesDataset.This PR aims to speed up the import by making the import of torch lazy.
It's a little bit tricky to keep all the dosctrings + auto-completion. For now, it seems the auto-completion is working fine for the instances, but not the
__init__docstrings.If you think this PR seems interesting, I can work on fixing the docstrings, else we can just close it